Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhanced details in agent query and read_state errors #970

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

krpeacock
Copy link
Contributor

Description

extends the work done for call errors to query and read_state.
Additionally:

  • fixes the thrown errors to use the same extended message as the logs
  • exports errors and ObservableLog into the library so they can be used externally for testing

How Has This Been Tested?

more tests

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 6, 2025 22:56
Copy link
Contributor

github-actions bot commented Feb 6, 2025

size-limit report 📦

Path Size
@dfinity/agent 72.77 KB (+0.11% 🔺)
@dfinity/candid 11.65 KB (0%)
@dfinity/principal 4.16 KB (0%)
@dfinity/auth-client 50.25 KB (+0.05% 🔺)
@dfinity/assets 68.03 KB (+0.06% 🔺)
@dfinity/identity 47.88 KB (-0.08% 🔽)
@dfinity/identity-secp256k1 107.1 KB (+0.4% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) February 7, 2025 17:42
@krpeacock krpeacock merged commit 767ebcc into main Feb 7, 2025
17 checks passed
@krpeacock krpeacock deleted the kaia/query-call-logging branch February 7, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants