Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverts read_state polling expiry changes #971

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

krpeacock
Copy link
Contributor

Description

Reverts #938

This introduced a bug because the signature is being re-used while the expiry is changed each time the request is made. This conflicts with the strategy of re-using requests in order to make the polling play well with hardware wallets, leading to invalid signatures. We will revert for now and re-evaluate

Fixes SDK-1958

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 7, 2025 17:57
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size
@dfinity/agent 72.59 KB (-0.26% 🔽)
@dfinity/candid 11.65 KB (0%)
@dfinity/principal 4.16 KB (0%)
@dfinity/auth-client 50.24 KB (-0.03% 🔽)
@dfinity/assets 67.83 KB (-0.3% 🔽)
@dfinity/identity 47.85 KB (-0.06% 🔽)
@dfinity/identity-secp256k1 106.87 KB (-0.22% 🔽)

@krpeacock krpeacock enabled auto-merge (squash) February 7, 2025 18:09
@krpeacock krpeacock merged commit c21fece into main Feb 7, 2025
16 checks passed
@krpeacock krpeacock deleted the kaia/SDK-1958-revert-readstate-expiry branch February 7, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants