Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added e2e test for CanisterStatus subnet path #978

Merged
merged 3 commits into from
Mar 12, 2025
Merged

test: added e2e test for CanisterStatus subnet path #978

merged 3 commits into from
Mar 12, 2025
+3,550 −4,027

Conversation

krpeacock
Copy link
Contributor

Description

I just wanted a simple reference for how to do this, and the additional test coverage doesn't hurt

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner March 11, 2025 22:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 72.01 KB (-0.8% 🔽)
@dfinity/candid 11.7 KB (+0.47% 🔺)
@dfinity/principal 4.21 KB (+1.11% 🔺)
@dfinity/auth-client 50.09 KB (-0.32% 🔽)
@dfinity/assets 67.84 KB (+0.02% 🔺)
@dfinity/identity 47.7 KB (-0.32% 🔽)
@dfinity/identity-secp256k1 106.59 KB (-0.26% 🔽)

@krpeacock krpeacock enabled auto-merge (squash) March 11, 2025 22:23
@krpeacock
Copy link
Contributor Author

don't mind the size-limit differences, just a side effect from updating the dependency after it hit an npm audit warning

@krpeacock krpeacock merged commit d79dc98 into main Mar 12, 2025
19 checks passed
@krpeacock krpeacock deleted the kaia/subnet-status-test branch March 12, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanosdev nathanosdev nathanosdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krpeacock @nathanosdev