test(sns): Add integration test for setting custom proposal topics #4170
Conversation
aterga
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
| ..initial_function.clone() | ||
| }; | ||
|
|
||
| // AddGenericNervousSystemFunction |
There was a problem hiding this comment.
I believe this comment can and should contain prose, since that is the standard way.
| .await | ||
| .unwrap(); | ||
|
|
||
| let proposal_id = SubmittedProposal::try_from(response) |
There was a problem hiding this comment.
I'm a bit confused why conversion is needed...
| .unwrap(); | ||
| } | ||
|
|
||
| // SetCustomProposalTopics |
There was a problem hiding this comment.
Prose?
Also, this is where we run the code under test, right?
| url: DUMMY_URL_FOR_PROPOSALS.to_string(), | ||
| action: Some(Action::SetCustomProposalTopics(SetCustomProposalTopics { | ||
| custom_function_id_to_topic: btreemap! { | ||
| 1111_u64 => Topic::ApplicationBusinessLogic, |
There was a problem hiding this comment.
I think _u64 prefix is not needed? Doesn't seem useful, but up to you.
This PR introduces a new type of SNS proposals, `SetCustomProposalTopics`, which can be used to batch-set topics for all custom proposals (or any non-empty subset thereof) at once. | [Next PR](#4170) >
This PR adds an integration test for the scenario in which the topic is changed for a custom SNS proposal type.
< Previous PR |