Jaikiran's feedback

dfuch · Nov 15, 2024 · b128391 · b128391
1 parent 30d6f8d
commit b128391
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 19 deletions.
diff --git a/src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java b/src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java
@@ -230,10 +230,6 @@ public static class FilePublisher implements BodyPublisher {
         private final long length;
         private final Function<Path, InputStream> inputStreamSupplier;
 
-        private static String checkPathForDefaultFS(Path path) {
-            return path.toFile().getPath();
-        }
-
         /**
          * Factory for creating FilePublisher.
          */
@@ -242,8 +238,9 @@ public static FilePublisher create(Path path)
             boolean defaultFS = true;
 
             try {
-                checkPathForDefaultFS(path);
+                path.toFile().getPath();
             } catch (UnsupportedOperationException uoe) {
+                // path not associated with the default file system provider
                 defaultFS = false;
             }
 

diff --git a/src/java.net.http/share/classes/jdk/internal/net/http/ResponseBodyHandlers.java b/src/java.net.http/share/classes/jdk/internal/net/http/ResponseBodyHandlers.java
@@ -52,10 +52,6 @@ public final class ResponseBodyHandlers {
 
     private ResponseBodyHandlers() { }
 
-    private static final String checkPathForDefaultFS(Path path) {
-        return path.toFile().getPath();
-    }
-
     /**
      * A Path body handler.
      */
@@ -146,7 +142,7 @@ public static class FileDownloadBodyHandler implements BodyHandler<Path> {
         public static FileDownloadBodyHandler create(Path directory,
                                                      List<OpenOption> openOptions) {
             try {
-                checkPathForDefaultFS(directory);
+                directory.toFile().getPath();
             } catch (UnsupportedOperationException uoe) {
                 // directory not associated with the default file system provider
                 throw new IllegalArgumentException("invalid path: " + directory, uoe);

diff --git a/src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java b/src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java
@@ -183,15 +183,6 @@ public static PathSubscriber create(Path file,
             this.options = options.stream().toArray(OpenOption[]::new);
         }
 
-        private static boolean isDefaultFS(Path file) {
-            try {
-                file.toFile();
-                return true;
-            } catch (UnsupportedOperationException uoe) {
-                return false;
-            }
-        }
-
         @Override
         public void onSubscribe(Flow.Subscription subscription) {
             Objects.requireNonNull(subscription);