v3: voice: udp.Manager for seamless reconnection #241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request breaks the previous v2 voice API to add in a
udp.Manager
that effectively manages reconnection of the voice UDP connection. This fixes a previous issue where changing the voice region would break the voice connection.The biggest breaking change in this PR (as far as voice sending goes) actually has nothing to do with this fix. The change is written below:
This change is made primarily for convenience.
A small side effect of this change is that the minimum supported Go version has been bumped to 1.16 for some reason. By the time v3 is finalized, however, Go 1.17 would've already been released, so this is fine.
This pull request fixes #238.