-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style guide #581
base: develop
Are you sure you want to change the base?
Style guide #581
Conversation
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
A very cool project that could come off the back of this is a linter, not sure if you're still in your work hackweek or if that's long gone but potentially one for that! |
I was thinking the same thing! I'll add that to the list of things for hackweek. It's the last week of January. Shopping it around this week to get some contributors. |
Ah perfect! Sounds really good! You could do it in Dictu, or even potentially in JS (TypeScript) and we could potentially merge it into the VSc plugin, just thinking out loud here |
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Created #593 to capture this bit of the convo. |
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
I'm happy to make changes on any of this based on how you (@Jason2605) want Dictu to be written. This was just some stuff I came up with based on how I found myself writing it. |
It's all good mate I'd agree with everything we have so far! Potentially may be quite a long living PR (sorry) until we add everything we want to be added to it |
Cool cool. Down for it to live forever if need be. 😀 |
I'll try not make it be forever haha, but cheers man |
Well detailed description of the change :
Initial attempt at drafting a style guide. Open to any and all suggestions.
Resolves: #
#532
Type of change:
Bug fix
New feature
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Housekeeping
Tests have been updated to reflect the changes done within this PR (if applicable).
Documentation has been updated to reflect the changes done within this PR (if applicable).
Preview (Screenshots) :