Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded file #733

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Conversation

briandowns
Copy link
Contributor

What's Changed:

Removes an unneeded file from the root of the repository.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Signed-off-by: Brian Downs <[email protected]>
@briandowns briandowns self-assigned this Jan 24, 2024
@briandowns briandowns requested a review from Jason2605 January 24, 2024 23:41
@Jason2605
Copy link
Member

We really need to look at that test, it seems to be failing on each run

@briandowns
Copy link
Contributor Author

Really strange how it's fine in one test and then consistently blows up in others, after having been fine for awhile.

Signed-off-by: Brian Downs <[email protected]>
@Jason2605
Copy link
Member

Hmmm looks as though this extended sleep is running forever on mac. Potentially work marking it as skipped for now and we can try look into it

@briandowns
Copy link
Contributor Author

yeah, that was a initial test and then my flight's WiFi went out so I had to wait a bit. I'll skip for now while I keep digging.

@Jason2605
Copy link
Member

Ah no worries at all mate! Thanks for the cleanup

@Jason2605 Jason2605 merged commit 25c7f1d into dictu-lang:develop Jan 28, 2024
7 of 8 checks passed
@briandowns briandowns deleted the remove_bad_file branch January 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants