Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs #735

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix docs #735

merged 2 commits into from
Jan 31, 2024

Conversation

liz3
Copy link
Contributor

@liz3 liz3 commented Jan 31, 2024 •
edited
Loading

Fix basic example in the docs

What's Changed:

There was a issue where http response was refactored at some point and that resulted that if you ran the example it it would error, further fixes some logic errors in the dict docs comments

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Jason2605
Jason2605 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Jason2605 Jason2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thanks!

@Jason2605 Jason2605 merged commit 8f6894b into dictu-lang:develop Jan 31, 2024
8 checks passed
@Jason2605 Jason2605 mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason2605 Jason2605 Jason2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liz3 @Jason2605