Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add reallocate and memory macros to ffi #743

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

liz3
Copy link
Contributor

@liz3 liz3 commented Aug 28, 2024

Add reallocate and memory macros to ffi

What's Changed:

I added reallocate to the FFI as a function and updated the ffi header for it to have the memory macros available.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

@Jason2605
Copy link
Member

Apologies for being slow, I'm currently in a different country! I will get around to this, thank you

@liz3
Copy link
Contributor Author

liz3 commented Sep 6, 2024

Thanks, i have been writing a few "addons"? and was in need of those macros.

@Jason2605
Copy link
Member

Woah these look really cool! It seems as though the tests are failing on OS X mind, we probably need to look into that

@liz3
Copy link
Contributor Author

liz3 commented Sep 7, 2024

Woah these look really cool! It seems as though the tests are failing on OS X mind, we probably need to look into that

Seams to be fixed, the issue was that the MacOS runner apparently started using arm64 and the shared object for the test was x64, this might be a idea to add a constant to System, like Node.js's process.arch in order to check that.

But in terms of this patch it seams to work!

@Jason2605
Copy link
Member

AHhh good find, thank you for this, much appreciated!

@Jason2605 Jason2605 merged commit cf77dc3 into dictu-lang:develop Sep 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants