execute didn't work when SQL ends with a comment
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `execute` with SQL like the following didn't work: ``` INSERT INTO t (x, y, z) VALUES (7, 7, 7); INSERT INTO t (x, y, z) VALUES (8, 8, 8); -- this is a comment at the end ``` Executing that SQL results in a `Extralite::Error: not an error` error because `prepare_multi_stmt_impl` can set `stmt` to `NULL` when SQL ends with a comment. The documentation for `sqlite3_prepare_v2` states: > If the input text contains no SQL (if the input is an empty string or a comment) then *ppStmt is set to NULL.
|
Great fix, thanks @gschlager ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
executewith SQL like the following didn't work:Executing that SQL results in a
Extralite::Error: not an errorerror becauseprepare_multi_stmt_implcan setstmttoNULLwhen SQL ends with a comment. The documentation forsqlite3_prepare_v2states: