-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue 511: ShapeCastHit has no details on ShapeCastStatus::Converged #521
Conversation
…ng from ShapeCastHit in parry to ShapeCastHit in bevy
@Vrixyz Thank you for approving! I see tests failing and they are definitely not failing because of my changes. Does it require actions from my side? |
@kirilllysenko CI fails are indeed not related, as you merged master in I think they'll pass now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After consideration, the correct condition is a bit more involved, see https://github.com/dimforge/bevy_rapier/pull/521/files#r1639994370
It's especially useful to read through ShapeCastStatus
doc to understand different cases.
…ng from ShapeCastHit in parry to ShapeCastHit in bevy
I did all of the requested changes |
This is a PR with suggested bug fix in issue #511. The fix seems also logical when looking at documentation for field
details
ofShapeCastHit
class: