Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in "'castShape' functions #280

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix typo in "'castShape' functions #280

merged 1 commit into from
Jun 13, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Jun 13, 2024 •
edited
Loading

I'm not 100% sure ; the sentence "on a path to exist that penetration state" feels a bit weird, I'm not sure if I could read it either:

  • "enter" that penetration state
  • or it's a typo ? "exit" that penetration state

@Vrixyz Vrixyz requested a review from sebcrozet June 13, 2024 08:43
sebcrozet
sebcrozet approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Yes it should be exit.

@Vrixyz Vrixyz mentioned this pull request Jun 13, 2024
Merged
@Vrixyz Vrixyz merged commit 34bd132 into dimforge:master Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet sebcrozet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vrixyz @sebcrozet