-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript code snippets #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
force-pushed
the
javascript-code-snippets
branch
from
June 11, 2024 14:57
2175a2d
to
30d9a4e
Compare
Vrixyz
force-pushed
the
javascript-code-snippets
branch
from
June 13, 2024 10:26
c5d4833
to
b8fdf38
Compare
Vrixyz
force-pushed
the
javascript-code-snippets
branch
from
June 13, 2024 13:41
e2a80da
to
5cd6819
Compare
Vrixyz
force-pushed
the
javascript-code-snippets
branch
from
June 13, 2024 16:09
da29bbe
to
5d60cbe
Compare
Vrixyz
force-pushed
the
javascript-code-snippets
branch
from
June 14, 2024 08:03
3b5bd87
to
7a5f5b5
Compare
Vrixyz
commented
Jun 14, 2024
Comment on lines
+107
to
+108
let data = new Map(); | ||
data.set(collider.handle, 10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about how user would store user data in a collider, I imagine in javascript they could add whatever they want on the type, but in typescript I believe there's no other choice than adding it externally ?
sebcrozet
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on https://github.com/dimforge/rapier.rs/pull/104 to provide a way to test more easily the javascript code snippets.
Diff so far: https://gist.github.com/Vrixyz/a627e66781f3fce62d4b39b85d02eb6b
Details
setAdditionalPrincipalAngularInertia
does not existsetEnabledRotations
->enabledRotations
,
->;
Collider
?