-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docusaurus 3 #111
Update Docusaurus 3 #111
Conversation
More info at facebook/docusaurus#9698
deps remark-math and rehype-katex updated
(not really related to this PR, but) on my linux, the |
…z/rapier.rs into docusaurus_3_cross_platform_inject
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Run injection script locally | ||
run: find docs/user_guides/templates/ -type f -print0 | OUTPUT_FOLDER=docs/user_guides/templates_injected xargs -0 ./inject_code_in_user_guides.sh | ||
- name: User guides generation | ||
run: ./generate_user_guides.sh | ||
- name: yarn install | ||
run: corepack enable && yarn | ||
- name: yarn build | ||
run: PUBLISH_MODE=1 yarn build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn build
tested on CI is great, it currently outputs some warning concerning links, which might be related to #41
A good follow up Pull Request would be to eliminate these warnings. From my testing these warnings don´t indicate regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes have been made to this script to make it more cross platform friendly. I tested on mac, windows, linux.
if [ gsed -v ]; then | ||
gsed=gsed | ||
else | ||
# Hopefully installed sed is the gnu one. | ||
# note: aliases work poorly with xargs. | ||
gsed=sed | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using gsed
is not trivial on linux actually, so this "hack" allows for better cross platform tooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fantastic, thank you!
Builds on #110