This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Fix #1926 (Adds UTC version of created_on field to the payload) #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code change fixing suppose to fix the issued described in the following tickets: #1926 https://github.com/directus/app/issues/2834 The created_on field is part of the update request for translations data, but its not converted to UTC when update is processing. It's causing TableGateway to fail when updateWith method is called
Added additional validation for existence of "created_on" field in payload and only then make an update.
yarick2000
changed the title
yarick2000
changed the title
rijkvanzanten
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change fixing suppose to fix the issued described in the following tickets:
Fixes #1926
Fixes https://github.com/directus/app/issues/2834
The created_on field is part of the update request for translations data, but its not converted to UTC when update is processing. It's causing TableGateway to fail when updateWith method is called