Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV Content Page Updates #148

Merged
merged 22 commits into from
Mar 29, 2024
Merged

TV Content Page Updates #148

merged 22 commits into from
Mar 29, 2024

Conversation

bryantgillespie
Copy link
Contributor

@bryantgillespie bryantgillespie commented Mar 26, 2024

  • Adds feedback widget for like, dislike, love
  • Adds recommendations to other episodes or content for episodes detail pages
  • Adds transcript to episode pages and JSON LD data

@bryantgillespie bryantgillespie marked this pull request as ready for review March 26, 2024 19:23
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for directus-website ready!

Name Link
🔨 Latest commit 1297123
🔍 Latest deploy log https://app.netlify.com/sites/directus-website/deploys/6606c191f1b0c600092302f1
😎 Deploy Preview https://deploy-preview-148--directus-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryantgillespie bryantgillespie marked this pull request as draft March 26, 2024 19:23
@bryantgillespie bryantgillespie marked this pull request as ready for review March 27, 2024 13:09
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the top margin on the notice element? The gap feels a bit odd


Should we add additional dividers on mobile devices? I'm thinking about at least one between the "About" and "Meta (Resources, People, ...) sections:

pages/tv/[show]/[episode].vue Show resolved Hide resolved
@phazonoverload
Copy link
Contributor

While I originally said I didn't want to surface the transcript in the UI, I like this tabbed approach. I'd suggest we also move the people, resources, and maybe even 'show details' into their own tabs.

@bryantgillespie
Copy link
Contributor Author

I'd suggest we also move the people, resources, and maybe even 'show details' into their own tabs.

People: let's keep as is. I like those are always visible. Especially for external guests.
Resources: 💯
Show Details: What would this cover?

@phazonoverload
Copy link
Contributor

Show description and tile can go down there. Maybe the number of episodes as well

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bryantgillespie bryantgillespie merged commit 0cc4117 into main Mar 29, 2024
6 checks passed
@bryantgillespie bryantgillespie deleted the tv-me-content branch March 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants