Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new VzLinux official image #11544

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktrushkin
Copy link

@ktrushkin ktrushkin commented Dec 17, 2021

Hello,

We would like to add new VzLinux image.

Thank you!

Checklist for Review

NOTE: This checklist is intended for the use of the Official Images maintainers both to track the status of your PR and to help inform you and others of where we're at. As such, please leave the "checking" of items to the repository maintainers. If there is a point below for which you would like to provide additional information or note completion, please do so by commenting on the PR. Thanks! (and thanks for staying patient with us ❤️)

  • associated with or contacted upstream?
  • available under an OSI-approved license?
    • GPL v2
  • does it fit into one of the common categories? ("service", "language stack", "base distribution")
    • base distribution
  • is it reasonably popular, or does it solve a particular use case well?
  • does a documentation PR exist? (should be reviewed and merged at roughly the same time so that we don't have an empty image page on the Hub for very long)
  • official-images maintainer dockerization review for best practices and cache gotchas/improvements (ala the official review guidelines)?
  • 2+ official-images maintainer dockerization review?
  • existing official images have been considered as a base? (ie, if foobar needs Node.js, has FROM node:... instead of grabbing node via other means been considered?)
  • if FROM scratch, tarballs only exist in a single commit within the associated history?
  • passes current tests? any simple new tests that might be appropriate to add? (https://github.com/docker-library/official-images/tree/master/test)

@ktrushkin
Copy link
Author

Are there any remarks?

@tianon
Copy link
Member

tianon commented Mar 25, 2022

Sorry for the delay! New image reviews usually take a lot more effort than image update review, so they often take a back seat (we're trying to be better about that). 🙇

I'd like to start by asking about the "popularity" aspect -- some of the normal metrics we use aren't really available here, presumably because it's so newly open source? 😅

@tianon
Copy link
Member

tianon commented Mar 25, 2022

I've also got a few comments about the Dockerization.


When you update this, you're going to need to force push to the branch to ensure there's only ever at most one tarball in the history (that the tarball doesn't get "updated" in the history of the provided commit). How I usually handle this in my own repositories is to have a "main" branch that includes the source code (Dockerfile, etc), and then a separate "dist" branch that only ever includes a single commit above "main" which includes the tarball (force pushed on each update). If you don't mind force-pushing to "main" the current structure is fine, but something to think about.


Regarding the labels, see #3540 (comment), especially:

We don't actively recommend using labels. If an image maintainer wants to have labels, that is fine, but label names should adhere to the image spec: https://github.com/opencontainers/image-spec/blob/v1.0.1/annotations.md

(label-schema has been deprecated for a long time now)


I'm not sure what RUN yum reinstall -y vzlinux-release is trying to accomplish -- can you elaborate on that? Why wouldn't the base tarball be updated instead? (It's also currently failing for me with Installed package vzlinux-release-3:8.5-36.vl8.x86_64 not available.)

@tianon
Copy link
Member

tianon commented Mar 25, 2022

Of the packages installed in the tarball, I'm curious about a few packages that maybe aren't necessary to be installed in the base container images? For example, all the boost-* packages and smartmontools.

@tianon
Copy link
Member

tianon commented Apr 5, 2024

I'm updating the status of this PR to "draft" for now. When it's ready for re-review, please remove the draft status and leave a comment (GitHub unfortunately does not notify maintainers for draft state changes).

@tianon tianon marked this pull request as draft April 5, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants