vendor: github.com/docker/docker 6c3797923dcb (master, v28.0-dev)

[thaJeztah]

vendor: github.com/docker/docker 6c3797923dcb (master, v28.0-dev)

full diff: moby/moby@6968719...6c37979

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

nothing too interesting, mostly updated to verify everything looks well after the containerd + buildkit update in moby

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.26%. Comparing base (11999b1) to head (01da8a5).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5754      +/-   ##
==========================================
- Coverage   59.28%   59.26%   -0.02%     
==========================================
  Files         353      353              
  Lines       29532    29540       +8     
==========================================
+ Hits        17507    17508       +1     
- Misses      11046    11052       +6     
- Partials      979      980       +1     

[vvoland]

#18 63.14 === FAIL: cli/command/trust TestSignCommandChangeListIsCleanedOnError (0.00s)
#18 63.14 panic: runtime error: invalid memory address or nil pointer dereference [recovered]
#18 63.14 	panic: runtime error: invalid memory address or nil pointer dereference
#18 63.14 [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7d3f8e]
#18 63.14 
#18 63.14 goroutine 143 [running]:
#18 63.14 testing.tRunner.func1.2({0xdb09e0, 0x1725d30})
#18 63.14 	/usr/local/go/src/testing/testing.go:1632 +0x230
#18 63.14 testing.tRunner.func1()
#18 63.14 	/usr/local/go/src/testing/testing.go:1635 +0x35e
#18 63.14 panic({0xdb09e0?, 0x1725d30?})
#18 63.14 	/usr/local/go/src/runtime/panic.go:785 +0x132
#18 63.14 net/http.(*Client).do(0x0, 0xc000342140)
#18 63.14 	/usr/local/go/src/net/http/client.go:606 +0x1ee
#18 63.14 net/http.(*Client).Do(...)
#18 63.14 	/usr/local/go/src/net/http/client.go:590
#18 63.14 github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).doRequest(0xc0001328c0, 0xc0001328c0?)
#18 63.14 	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:141 +0x6d
#18 63.14 github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).sendRequest(0xc0001328c0, {0x1062ad0, 0x17782c0}, {0xeed551, 0x3}, {0xc00001b0f8?, 0xcb00000000d1e220?}, 0x1?, {0x0, 0x0}, ...)
#18 63.14 	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:125 +0xde
#18 63.14 github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).get(...)
#18 63.14 	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:37
#18 63.14 github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).ImageInspect(_, {_, _}, {_, _}, {_, _, _})
#18 63.14 	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/image_inspect.go:78 +0x405
#18 63.14 github.com/docker/cli/cli/command/trust.checkLocalImageExistence(...)
#18 63.14 	/go/src/github.com/docker/cli/cli/command/trust/sign.go:143

Ah, looks like the fakeClient needs updating with the new ImageInspect function

[thaJeztah]

Yup, I missed one; I think I have them all now 👍

[thaJeztah]

derp; still more 😢

[thaJeztah]

Weird; that one runs fine locally;

#18 63.13 === FAIL: cli/command/image TestNewInspectCommandSuccess (0.00s)
#18 63.13 panic: runtime error: invalid memory address or nil pointer dereference [recovered]
#18 63.13 	panic: runtime error: invalid memory address or nil pointer dereference
#18 63.13 [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7e90ce]
#18 63.13 
#18 63.13 goroutine 60 [running]:
#18 63.13 testing.tRunner.func1.2({0xdd4aa0, 0x1773f70})
#18 63.13 	/usr/local/go/src/testing/testing.go:1632 +0x230
#18 63.13 testing.tRunner.func1()
#18 63.13 	/usr/local/go/src/testing/testing.go:1635 +0x35e
#18 63.13 panic({0xdd4aa0?, 0x1773f70?})

[vvoland]

Also, seems related to the latest v stripping changes on moby:

--- FAIL: TestNewAPIClientFromFlagsWithAPIVersionFromEnv (0.00s)
    cli_test.go:134: assertion failed: 3.3.3 (string) != v3.3.3 (customVersion string)

[thaJeztah]

Yup; fixed that one as well; value should only be used for checking actual API versions, so I think we should be good with that output changing.

[vvoland]

While you're at it... You may update this one to moby/moby@6c37979 already 😅

[thaJeztah]

Ah, was vendoring already 😄

[vvoland]

 --- FAIL: TestPrunePromptTermination (0.01s)
    prune_test.go:128: assertion failed: error is "image prune has been cancelled" (errdefs.errCancelled), not "prompt terminated" (command.ErrPromptTerminated errdefs.errCancelled)
FAIL
coverage: 52.0% of statements
FAIL	github.com/docker/cli/cli/comma

flaky?

EDIT: yep, opened: #5802

[vvoland]

LGTM, thanks!