Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cmake_minimum_required to 3.5 #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eaaltonen
Copy link
Contributor

Increase cmake_minimum_required to address the below warning when building on CMake version 3.27 on Debian unstable:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

Commit

  • Increase cmake_minimum_required to 3.5

CMake version 3.27 deprecates compatibility with versions older than 3.5. Increase the minimum required so that the project can be built without warnings.

CMake version 3.27 deprecates compatibility with versions older than
3.5. Increase the minimum required so that the project can be built
without warnings.
@jaredgrubb
Copy link
Member

I'm not a Cmake expert. Are you aware of any version issues in our usage of Make?

@eaaltonen
Copy link
Contributor Author

https://gitlab.kitware.com/cmake/cmake/-/issues/25196 seems like a/the relevant CMake issue. As far as I can tell, at the moment this is "just" a warning.

So merge choice here would according to how much value one places to compatibility with the latest vs. compatibility with the very old.

Informally the versions were selected based on Ubuntu LTS versions. Ubuntu 14.04 packaged CMake 2.8.12.2, and Ubuntu 16.04 packaged CMake 3.5.

Based on the above I'm in favor of increasing the minimum.

@mlund
Copy link

mlund commented Jul 25, 2024

I use docopt.cpp in a project and worry that the deprecation warning becomes a hard error in the future. For a similar discussion, see pybind/pybind11_json#64. CMake 3.5 was released in 2016 so it's reasonably safe to assume that most users can meet that requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants