Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Table of Contents link is external, do not try to add base url #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kzap
Copy link

@kzap kzap commented Aug 13, 2017

* [External Link to Github](https://github.com)
* [Email Me](mailto:[email protected])

To go with docpress/docpress-core#196 This will allow absolute links in the Table of Contents properly

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.152% when pulling eeef317 on kzap:feature/external-links into 3eacc60 on docpress:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 13, 2017

Coverage Status

Coverage remained the same at 81.152% when pulling eeef317 on kzap:feature/external-links into 3eacc60 on docpress:master.

@knownasilya
Copy link
Member

Any chance you can add a test for this?

@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage remained the same at 81.152% when pulling 2cee6f3 on kzap:feature/external-links into 3eacc60 on docpress:master.

@kzap
Copy link
Author

kzap commented Aug 14, 2017

added commit from my other PR #243

Will see if I can make a testcase

@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage increased (+3.1%) to 84.293% when pulling 04631d3 on kzap:feature/external-links into 3eacc60 on docpress:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants