Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply SKIP LOCKED optimization for reserving a delayed job entry #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply SKIP LOCKED optimization for reserving a delayed job entry #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/delayed/backend/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def self.reserve_with_scope_using_optimized_sql(ready_scope, worker, now)
# use 'FOR UPDATE' and we would have many locking conflicts
quoted_table_name = connection.quote_table_name(table_name)
subquery_sql = ready_scope.limit(1).lock(true).select("id").to_sql
reserved = find_by_sql(["UPDATE #{quoted_table_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery_sql}) RETURNING *", now, worker.name])
reserved = find_by_sql(["UPDATE #{quoted_table_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery_sql} SKIP LOCKED) RETURNING *", now, worker.name])
reserved[0]
when "MySQL", "Mysql2"
# Removing the millisecond precision from now(time object)
Expand Down