-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The timing of the doneEach
hook call for the cover
#2427
base: develop
Are you sure you want to change the base?
Conversation
The `doneEach` hook function for the cover should be called after the cover page HTML has been appended to the DOM.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks of this, @YiiGuxing. Can you add some tests to |
@jhildenbiddle. Completed. Please review. |
@jhildenbiddle, I found that this PR does not work in the asynchronous mode of |
@jhildenbiddle, The fact that the cover doesn't work in asynchronous mode on Additionally, regarding the |
Summary
The
doneEach
hook function for the cover should be called after the cover page HTML has been appended to the DOM.Related issue, if any:
What kind of change does this PR introduce?
Feature
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: