-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: file upload #1749
base: master
Are you sure you want to change the base?
feat: file upload #1749
Conversation
This pull request is being automatically deployed with Vercel (learn more). dojo.widgets – ./🔍 Inspect: https://vercel.com/dojo/dojo.widgets/Db2mP9AuBtAmjncLajjSAdngV2cV [Deployment for 2c345ba failed] widget-test-docs – ./🔍 Inspect: https://vercel.com/dojo/widget-test-docs/Bivv4DTqhp2NbFkPFZwDUXgusUhF [Deployment for 2c345ba failed] |
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
- Coverage 90.46% 90.32% -0.15%
==========================================
Files 94 98 +4
Lines 5152 5284 +132
Branches 1406 1445 +39
==========================================
+ Hits 4661 4773 +112
- Misses 241 250 +9
- Partials 250 261 +11
Continue to review full report at Codecov.
|
Why was DnD dropped? That seems like a key feature of a file upload widget. I don't see that |
@msssk I chose to remove drag-and-drop for this first version of the file upload components since it adds a lot of complexity. I agree that it's a nice to have feature (though getting less common in practice) but I don't think it's required to accomplish the end goal of uploading files and managing them. |
@bitpshr there seems to be typescript errors |
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This pull request introduces two new widgets to help support file uploads,
FileUploadInput
for simple uploads, andFileUploader
for more complex upload management.Resolves #1129
Replaces #1540
Preview