Expose current time in Broker
#208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-steinke
approved these changes
May 13, 2024
kilianp14
approved these changes
May 22, 2024
|
Right, I didn't notice the merge conflicts, I fixed them now :) |
|
We're currently discussing a redesign of the actor interface and are putting development of the SiL module and also the Broker as this will probably influence their interface as well. |
|
I will check for compatibility with our new stuff and merge in the next couple of days :) |
Merged
birnbaum
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have another small suggested addition. This PR is less important to me than the other PRs made this week.
Instead of having to assume the current time (which I do now) or extracting it as the last value from one of the time series, it could be helpful to export this property, too.
Another (only indirectly related) aspect one may want to think about converting these times (or their type annotations) to a common representation, too. (Some kind of datetime object instead of a DatetimeLike.)