Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made All Vessim Imports Top-Level #210

Merged
merged 4 commits into from
May 23, 2024
Merged

Made All Vessim Imports Top-Level #210

merged 4 commits into from
May 23, 2024

Conversation

marvin-steinke
Copy link
Contributor

@marvin-steinke marvin-steinke commented May 22, 2024 •
edited
Loading

  • Should the old modules still remain in __all__ for backwards compatibility?
  • Should we also use this top lvl structure within the vessim package e.g. in vessim.actor to import other vessim packages?

@marvin-steinke marvin-steinke marked this pull request as ready for review May 22, 2024 15:02
@marvin-steinke marvin-steinke requested a review from kilianp14 May 22, 2024 15:02
@marvin-steinke marvin-steinke requested a review from birnbaum May 23, 2024 09:42
@marvin-steinke
Copy link
Contributor Author

marvin-steinke commented May 23, 2024 •
edited
Loading

TODO: API refs
Update: Procrastinate until new Actor interface is implemented

@marvin-steinke marvin-steinke merged commit 7be55b5 into main May 23, 2024
4 checks passed
@marvin-steinke marvin-steinke deleted the top_lvl branch May 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birnbaum birnbaum birnbaum approved these changes

@kilianp14 kilianp14 kilianp14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvin-steinke @birnbaum @kilianp14