Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #234 #235

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Fix #234 #235

merged 4 commits into from
Sep 9, 2024

Conversation

marvin-steinke
Copy link
Contributor

@marvin-steinke marvin-steinke commented Sep 3, 2024

  • For Dataframes, we're now checking for equal column names and raise an error in case
  • For Series, their name is no longer used as column name in _resample_to_frequency(). Series are identified by checking the length of self._actual (=1)

closes #234

Thank you @Impelon for the detailed bug report. If you have further thoughts about this, please let us know!

@marvin-steinke marvin-steinke merged commit 5bdcb81 into main Sep 9, 2024
4 checks passed
@marvin-steinke marvin-steinke deleted the fix_#234 branch September 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HistoricalSignal: Series names need to be equal
2 participants