Adding public API test coverage for Aspire.Hosting.Valkey #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
56 tasks
radical
added
area-app-model
…-methods#aspire-hosting-valkey
radical
reviewed
Jul 30, 2024
| #region ValkeyBuilderExtensions | ||
|
|
||
| [Fact] | ||
| public void AddValkeyContainerShouldThrowsWhenBuilderIsNull() |
There was a problem hiding this comment.
nit: ShouldThrows -> ShouldThrow
Zombach
reviewed
Jul 30, 2024
|
|
||
| var action = () => builder.AddValkey(name); | ||
|
|
||
| Assert.Multiple(() => |
There was a problem hiding this comment.
Based on this comment. Assert.Multyple is not necessary.
You should just leave it here:
var exception = Assert.Throws(action);
Assert.Equal(nameof(builder), exception.ParamName);
Same for the code below
…-methods#aspire-hosting-valkey
…-methods#aspire-hosting-valkey
Zombach
approved these changes
Jul 30, 2024
…-methods#aspire-hosting-valkey
bell-nat
changed the title
Zombach
reviewed
Aug 1, 2024
| [Fact] | ||
| public void AddValkeyContainerShouldThrowWhenNameIsNull() | ||
| { | ||
| IDistributedApplicationBuilder builder = new DistributedApplicationBuilder([]); |
There was a problem hiding this comment.
Use TestDistributedApplicationBuilder.Create();
| { | ||
| string name = null!; | ||
|
|
||
| var action = () => new ValkeyResource(name); |
There was a problem hiding this comment.
Add a static check in the class
private static string ThrowIfNull([NotNull] string? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
=> argument ?? throw new ArgumentNullException(paramName);
Zombach
reviewed
Aug 1, 2024
|
|
||
| public class ValkeyPublicApiTests | ||
| { | ||
| #region ValkeyBuilderExtensions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial issues #2649
Issues Check List: Validate arguments of public methods
Microsoft Reviewers: Open in CodeFlow