Adding public API test coverage for Aspire.Hosting.Elasticsearch

src/Aspire.Hosting.Elasticsearch/ElasticsearchBuilderExtensions.cs

@@ -44,6 +44,9 @@ public static IResourceBuilder<ElasticsearchResource> AddElasticsearch(
         IResourceBuilder<ParameterResource>? password = null,
         int? port = null)
     {
+        ArgumentNullException.ThrowIfNull(name);
+        ArgumentNullException.ThrowIfNull(builder);
+
         var passwordParameter = password?.Resource ?? ParameterResourceBuilderExtensions.CreateDefaultPasswordParameter(builder, $"{name}-password");
 
         var elasticsearch = new ElasticsearchResource(name, passwordParameter);
@@ -82,7 +85,11 @@ public static IResourceBuilder<ElasticsearchResource> AddElasticsearch(
     /// </code>
     /// </example>
     public static IResourceBuilder<ElasticsearchResource> WithDataVolume(this IResourceBuilder<ElasticsearchResource> builder, string? name = null)
-        => builder.WithVolume(name ?? VolumeNameGenerator.CreateVolumeName(builder, "data"), "/usr/share/elasticsearch/data");
+    {
+        ArgumentNullException.ThrowIfNull(builder);
+
+        return builder.WithVolume(name ?? VolumeNameGenerator.CreateVolumeName(builder, "data"), "/usr/share/elasticsearch/data");
+    }
 
     /// <summary>
     /// Adds a bind mount for the data folder to a Elasticseach container resource.
@@ -105,6 +112,10 @@ public static IResourceBuilder<ElasticsearchResource> WithDataVolume(this IResou
     /// </code>
     /// </example>
     public static IResourceBuilder<ElasticsearchResource> WithDataBindMount(this IResourceBuilder<ElasticsearchResource> builder, string source)
-        => builder.WithBindMount(source, "/usr/share/elasticsearch/data");
+    {
+        ArgumentNullException.ThrowIfNull(builder);
+        ArgumentNullException.ThrowIfNull(source);
 
+        return builder.WithBindMount(source, "/usr/share/elasticsearch/data");
+    }
 }

src/Aspire.Hosting.Elasticsearch/ElasticsearchResource.cs

@@ -26,6 +26,7 @@ public class ElasticsearchResource : ContainerResource, IResourceWithConnectionS
     /// <param name="password">A parameter that contains the Elasticsearch superuser password.</param>
     public ElasticsearchResource(string name, ParameterResource password) : base(name)
     {
+        ArgumentNullException.ThrowIfNull(name);
         ArgumentNullException.ThrowIfNull(password);
         PasswordParameter = password;
     }

tests/Aspire.Hosting.Elasticsearch.Tests/ElasticsearchPublicApiTests.cs

@@ -0,0 +1,116 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using Aspire.Hosting.ApplicationModel;
+using Xunit;
+
+namespace Aspire.Hosting.Elasticsearch.Tests;
+
+public class ElasticsearchPublicApiTests
+{
+    [Fact]
+    public void AddElasticsearchContainerShouldThrowsWhenBuilderIsNull()
+    {
+        IDistributedApplicationBuilder builder = null!;
+        const string name = "Elasticsearch";
+
+        var action = () => builder.AddElasticsearch(name);
+
+        Assert.Multiple(() =>
+        {
+            var exception = Assert.Throws<ArgumentNullException>(action);
+            Assert.Equal(nameof(builder), exception.ParamName);
+        });
+    }
+
+    [Fact]
+    public void AddElasticsearchContainerShouldThrowsWhenNameIsNull()
+    {
+        IDistributedApplicationBuilder builder = new DistributedApplicationBuilder([]);
+        string name = null!;
+
+        var action = () => builder.AddElasticsearch(name);
+
+        Assert.Multiple(() =>
+        {
+            var exception = Assert.Throws<ArgumentNullException>(action);
+            Assert.Equal(nameof(name), exception.ParamName);
+        });
+    }
+
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public void WithDataShouldThrowsWhenBuilderIsNull(bool useVolume)
+    {
+        IResourceBuilder<ElasticsearchResource> builder = null!;
+
+        Func<IResourceBuilder<ElasticsearchResource>>? action = null;
+
+        if (useVolume)
+        {
+            action = () => builder.WithDataVolume();
+        }
+        else
+        {
+            const string source = "/data";
+
+            action = () => builder.WithDataBindMount(source);
+        }
+
+        Assert.Multiple(() =>
+        {
+            var exception = Assert.Throws<ArgumentNullException>(action);
+            Assert.Equal(nameof(builder), exception.ParamName);
+        });
+    }
+
+    [Fact]
+    public void WithDataBindMountShouldThrowsWhenSourceIsNull()
+    {
+        var builder = new DistributedApplicationBuilder([]); 
+        var resourceBuilder = builder.AddElasticsearch("Elasticsearch");
+
+        string source = null!;
+
+        var action = () => resourceBuilder.WithDataBindMount(source);
+
+        Assert.Multiple(() =>
+        {
+            var exception = Assert.Throws<ArgumentNullException>(action);
+            Assert.Equal(nameof(source), exception.ParamName);
+        });
+    }
+
+    [Fact]
+    public void CtorElasticsearchResourceShouldThrowsWhenNameIsNull()
+    {
+        var builder = new DistributedApplicationBuilder([]);
+        builder.Configuration["Parameters:Password"] = "p@ssw0rd";
+        var password = builder.AddParameter("Password");
+        const string name = null!;
+
+        var action = () => new ElasticsearchResource(name, password.Resource);
+
+        Assert.Multiple(() =>
+        {
+            var exception = Assert.Throws<ArgumentNullException>(action);
+            Assert.Equal(nameof(name), exception.ParamName);
+        });
+    }
+    [Fact]
+    public void CtorElasticsearchResourceShouldThrowsWhenPasswordIsNull()
+    {
+        var builder = new DistributedApplicationBuilder([]);
+        const string name = "Elasticsearch";
+        ParameterResource password = null!;
+
+        var action = () => new ElasticsearchResource(name, password);
+
+        Assert.Multiple(() =>
+        {
+            var exception = Assert.Throws<ArgumentNullException>(action);
+            Assert.Equal(nameof(password), exception.ParamName);
+        });
+    }
+}