Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding public API test coverage for Microsoft.Extensions.ServiceDiscovery.Dns #5225

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Adding public API test coverage for Microsoft.Extensions.ServiceDiscovery.Dns #5225

merged 1 commit into from
Aug 9, 2024

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Aug 8, 2024 •
edited
Loading

Initial issues #2649
Issues #5047

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 8, 2024
@sebastienros sebastienros merged commit 657cd8a into dotnet:main Aug 9, 2024
11 checks passed
@Zombach Zombach mentioned this pull request Aug 9, 2024
Open
56 tasks
@Zombach Zombach deleted the zombach/validate-arguments-of-public-methods#microsoft-extensions-service-discovery-dns branch August 14, 2024 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
area-service-discovery community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zombach @sebastienros