Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding public API test coverage #5402

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Adding public API test coverage #5402

wants to merge 31 commits into from

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Aug 23, 2024 •
edited
Loading

Initial issues #2649
Issues #5047
message

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Added public API test coverage for:

  • Aspire.Azure.Messaging.EventHubs
  • Aspire.Azure.Messaging.ServiceBus
  • Aspire.Azure.Messaging.WebPubSub
  • Aspire.Azure.Storage.Blobs
  • Aspire.Microsoft.Data.SqlClient
  • Aspire.Microsoft.EntityFrameworkCore.Cosmos
  • Aspire.Microsoft.EntityFrameworkCore.SqlServer
  • Aspire.MySqlConnector
  • Aspire.Npgsql
  • Aspire.Npgsql.EntityFrameworkCore.PostgreSQL
  • Aspire.Oracle.EntityFrameworkCore
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Aug 23, 2024
@Zombach Zombach marked this pull request as draft August 23, 2024 17:03
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 23, 2024
@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

@Alirexaa Hello, this is for the next group

@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

Aspire.Azure.Messaging.EventHubs

@Zombach Zombach mentioned this pull request Aug 23, 2024
Open
56 tasks
@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

Aspire.Azure.Messaging.ServiceBus
Aspire.Azure.Messaging.WebPubSub

@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

Aspire.Azure.Storage.Blobs

@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

Aspire.Microsoft.Data.SqlClient
Aspire.Microsoft.EntityFrameworkCore.Cosmos
Aspire.Microsoft.EntityFrameworkCore.SqlServer

@build-analysis build-analysis bot mentioned this pull request Aug 23, 2024
Open
3 tasks
@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

Aspire.MySqlConnector
Aspire.Npgsql
Aspire.Npgsql.EntityFrameworkCore.PostgreSQL
Aspire.Oracle.EntityFrameworkCore

@build-analysis build-analysis bot mentioned this pull request Aug 24, 2024
Open
@Zombach
Copy link
Contributor Author

Zombach commented Aug 25, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 5402 in repo dotnet/aspire

@Zombach Zombach changed the title Adding public API test coverage(DRAFT) Adding public API test coverage Aug 31, 2024
@Zombach Zombach marked this pull request as ready for review August 31, 2024 08:01
@build-analysis build-analysis bot mentioned this pull request Sep 16, 2024
Open
Zombach and others added 12 commits September 20, 2024 00:53
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
1c2ca1b 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
a7e4367 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
5a8897c 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
79065a0 
…part-2
@Zombach
Merge branch 'main' into validate-arguments-of-public-methods#part-2
5272a41
@Zombach
remove space
6b633b4
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
4f25b05 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
e37ba62 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
10936ac 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
1216ec3 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
51273dd 
…part-2
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
60db66f 
…part-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radical radical Awaiting requested review from radical radical is a code owner

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

@sebastienros sebastienros Awaiting requested review from sebastienros sebastienros is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow. intentionally a different color! community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zombach