-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split off "hide timestamp" setting from rest of console log state #7220
Split off "hide timestamp" setting from rest of console log state #7220
Conversation
…and remove timestamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs:315
- Ensure that all references to the renamed method
ToggleTimestampAsync
are updated accordingly.
private async Task ToggleTimestampAsync(bool hideTimestamp)
src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs:548
- Add tests to cover the new
ConsoleLogTimestampState
class to ensure it works as expected.
public record ConsoleLogTimestampState(bool HideTimestamp);
await this.AfterViewModelChangedAsync(_contentLayout, waitToApplyMobileChange: false); | ||
await SessionStorage.SetAsync(HideTimestampStorageKey, new ConsoleLogTimestampState(HideTimestamp: hideTimestamp)); | ||
_hideTimestamp = hideTimestamp; | ||
StateHasChanged(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this nessessary? I would have thought that it would be triggered automatically after the click event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This also removes it from the query string.
Fixes #7137
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):