Skip to content

Commit

Permalink
Revert "Quarantine flaky MVC functional tests (#55935)"
Browse files Browse the repository at this point in the history
This reverts commit 06c2466.
  • Loading branch information
BrennanConroy committed Jul 3, 2024
1 parent c02ff12 commit 8e39bb6
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;

namespace Microsoft.AspNetCore.Mvc.FunctionalTests;

Expand All @@ -13,7 +12,6 @@ public ClientValidationOptionsTests(MvcTestFixture<RazorPagesWebSite.Startup> fi

public MvcTestFixture<RazorPagesWebSite.Startup> Fixture { get; }

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55926")]
[Fact]
public async Task DisablingClientValidation_DisablesItForPagesAndViews()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using AngleSharp.Parser.Html;
using BasicWebSite;
using BasicWebSite.Services;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.Extensions.DependencyInjection;

Expand Down Expand Up @@ -36,7 +35,6 @@ public async Task Renders_BasicComponent()
AssertComponent("<p>Hello world!</p>", "Greetings", content);
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55928")]
[Fact]
public async Task Renders_RoutingComponent()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.Text.Json;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Testing;
using RoutingWebSite;

Expand All @@ -24,7 +23,6 @@ public ControllerEndpointFiltersTest(MvcTestFixture<StartupForEndpointFilters> f

public WebApplicationFactory<StartupForEndpointFilters> Factory { get; }

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55929")]
[Fact]
public async Task CanApplyEndpointFilterToController()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public HtmlGenerationWithCultureTest(

public HttpClient Client { get; }

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/4907")]
[Fact]
public async Task CacheTagHelper_AllowsVaryingByCulture()
{
Expand Down Expand Up @@ -76,7 +75,6 @@ void ReadValuesFromDocument()
}
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/4907")]
[Fact]
public async Task CacheTagHelper_AllowsVaryingByUICulture()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Net.Http;
using System.Net.Http.Json;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Testing;
using RoutingWebSite;

Expand All @@ -22,7 +21,6 @@ public RoutingAcrossPipelineBranchesTests(MvcTestFixture<RoutingWebSite.StartupR

public WebApplicationFactory<StartupRoutingDifferentBranches> Factory { get; }

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55933")]
[Fact]
public async Task MatchesConventionalRoutesInTheirBranches()
{
Expand Down
2 changes: 0 additions & 2 deletions src/Mvc/test/Mvc.FunctionalTests/RoutingDynamicOrderTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Net.Http;
using System.Net.Http.Json;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Testing;
using RoutingWebSite;

Expand Down Expand Up @@ -43,7 +42,6 @@ public async Task PrefersAttributeRoutesOverDynamicControllerRoutes()
Assert.Equal("AttributeRouteSlug", content.RouteName);
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55934")]
[Fact]
public async Task DynamicRoutesAreMatchedInDefinitionOrderOverPrecedence()
{
Expand Down
2 changes: 0 additions & 2 deletions src/Mvc/test/Mvc.FunctionalTests/RoutingGroupsTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using System.Net.Http.Json;
using System.Text.Json;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Testing;
using RoutingWebSite;
Expand All @@ -24,7 +23,6 @@ public RoutingGroupsTests(MvcTestFixture<StartupForGroups> fixture)

public WebApplicationFactory<StartupForGroups> Factory { get; }

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55931")]
[Fact]
public async Task MatchesControllerGroup()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Net.Http.Json;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Testing;
using RoutingWebSite;

Expand All @@ -22,7 +21,6 @@ public RoutingGroupsWithMetadataTests(MvcTestFixture<StartupForRouteGroupsWithMe

public WebApplicationFactory<StartupForRouteGroupsWithMetadata> Factory { get; }

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55927")]
[Fact]
public async Task OrderedGroupMetadataForControllers()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using BasicWebSite;
using BasicWebSite.Controllers;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.AspNetCore.Mvc.Testing.Handlers;
using Microsoft.AspNetCore.TestHost;
Expand Down Expand Up @@ -137,7 +136,6 @@ public async Task TestingInfrastructure_RedirectHandlerHandlesRelativeLocation()
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/55932")]
[Fact]
public async Task TestingInfrastructure_RedirectHandlerFollowsStatusCode303()
{
Expand Down

0 comments on commit 8e39bb6

Please sign in to comment.