Enable input number component to support type='range' attribute #55583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te specified by the user to take precedence over the default 'type="number"'. By swapping the order in which attributes are added to the builder, any user-defined 'type' attribute is now respected, enabling the usage of different input types like 'range'. Previously, the InputNumber component hardcoded the 'type' attribute as 'number', which prevented using it for other input types such as sliders (range inputs).
… attribute overrides the default.
…rt-type='range'-Attribute
dotnet-policy-service
bot
added
the
community-contribution
…ed type override the default
…tribute' of https://github.com/MattyLeslie/aspnetcore into Enable-InputNumber-Component-to-Support-type='range'-Attribute
…e input element and attributes
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
Commenter does not have sufficient privileges for PR 55583 in repo dotnet/aspnetcore |
…rt-type='range'-Attribute
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…rt-type='range'-Attribute
|
@MackinnonBuck, may I please request a review on this. |
There was a problem hiding this comment.
Thanks for working on this, @MattyLeslie!
The framework change looks good - I've just added some comments about the test code 🙂
Co-authored-by: Mackinnon Buck <[email protected]>
Co-authored-by: Mackinnon Buck <[email protected]>
Co-authored-by: Mackinnon Buck <[email protected]>
MackinnonBuck
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable input number component to support type='range' attribute
Summary of the changes
Modified the
InputNumbercomponent to allow the 'type' attribute specified by the user to take precedence over the default 'type="number"'. By swapping the order in which attributes are added to the builder, any user-defined 'type' attribute is now respected, enabling the usage of different input types like 'range'.Added a unit test to
InputNumberTeststo ensure the user definedtypeattribute overrides the defaultFixes #52067 by ensuring the type of the InputNumber component can be specified.