Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix urls in ProjectTemplates/README #55984

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Fix urls in ProjectTemplates/README #55984

merged 2 commits into from
Jun 20, 2024

Conversation

sebastienros
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 31, 2024
amcasey
amcasey approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious to me why this would be necessary, but I trust that you've actually clicked the links.

@sebastienros
Copy link
Member Author

@amcasey the current links don't work because it creates a relative link to the doc page

Screenshot 2024-06-06 165427

@sebastienros
Copy link
Member Author

@halter73 could use your superpowers to merge it

@halter73
Copy link
Member

/azp run

@halter73 halter73 enabled auto-merge (squash) June 10, 2024 23:30
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sebastienros
Copy link
Member Author

It's just a README, do we need the build to pass? Do we have markdown verification steps?

@halter73
Copy link
Member

No. It's just that I've already unassigned myself from the aspnet-build team, and this seemed easier than hassling Javier.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 18, 2024
captainsafia
captainsafia approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc: @wtgodbe for merge powers

@wtgodbe wtgodbe disabled auto-merge June 20, 2024 17:21
@wtgodbe wtgodbe merged commit de37915 into main Jun 20, 2024
19 of 22 checks passed
@wtgodbe wtgodbe deleted the sebros/readmeurls branch June 20, 2024 17:21
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview6 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
9.0-preview6
Development

Successfully merging this pull request may close these issues.
5 participants
@sebastienros @halter73 @captainsafia @amcasey @wtgodbe