Use the live crossgen2 corresponding to the runtime we're building against #59551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 lookup (when they should only influence old crossgen lookup)
…jects (where we use R2R)
dotnet-issue-labeler
bot
added
the
area-infrastructure
2 tasks
wtgodbe
approved these changes
Dec 18, 2024
ViktorHofer
reviewed
Dec 19, 2024
mmitche
reviewed
Dec 19, 2024
mmitche
reviewed
Dec 19, 2024
mmitche
reviewed
Dec 19, 2024
src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
Show resolved
Hide resolved
mmitche
approved these changes
Dec 19, 2024
dotnet-policy-service
bot
added
the
pending-ci-rerun
jkoritzinsky
removed
the
pending-ci-rerun
ViktorHofer
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build our shared frameworks in the VMR like how we build them in the Microsoft build, we need to run crossgen2 on them to pre-JIT code. However, in the VMR we currently don't have a crossgen2 that runs on the host.
dotnet/runtime#110676 has the runtime changes to provide such a crossgen2 in the VMR environment.
This PR makes the required changes to use this crossgen2 in the aspnetcore build in the VMR (as well as work around some SDK issues along the way).