Extends MinimalPermissionsPlugin to log minimal permissions. Closes #1083 #1085
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrytrinder
force-pushed
the
minimalpermissionsplugin-log
branch
from
43de255 to
cf240af
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR extends the MinimalPermissionsPlugin to log minimal permissions and addresses issue #1083.
- Introduces a log statement that outputs minimal permissions after recording stops.
- Enhances troubleshooting by providing visibility into the minimal permissions utilized.
Comments suppressed due to low confidence (1)
dev-proxy-plugins/RequestLogs/MinimalPermissionsPlugin.cs:140
- [nitpick] The log message token '{MinimalScopes}' does not clearly reflect that the logged data represents minimal permissions. Consider renaming the token to '{MinimalPermissions}' for better clarity.
Logger.LogInformation("Minimal permissions: {MinimalScopes}", string.Join(", ", result.MinimalPermissions));
garrytrinder
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends MinimalPermissionsPlugin to log minimal permissions. Closes #1083