-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aspire support to chat template #6102
Conversation
...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json
Show resolved
Hide resolved
....Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Program.cs
Show resolved
Hide resolved
...AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Directory.Build.targets.in
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Services/Ingestion/PDFDirectorySource.cs
Show resolved
Hide resolved
...I.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Services/JsonVectorStore.cs
Show resolved
Hide resolved
...lates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.sln
Outdated
Show resolved
Hide resolved
I'm going to undraft this PR so it can get some eyes. Note that there are some known issues I still need to address:
|
...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json
Outdated
Show resolved
Hide resolved
…tWithCustomData/.template.config/template.json Co-authored-by: Steve Sanderson <[email protected]>
...src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/ChatWithCustomData-CSharp.Web.csproj.in
Show resolved
Hide resolved
...tensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs
Outdated
Show resolved
Hide resolved
...tensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs
Outdated
Show resolved
Hide resolved
....Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Program.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done any testing; I've just reviewed, but this is looking really good, @MackinnonBuck.
I noted we have 2 places where we're depending on recent changes in the libraries, which means we will need to wait to publish this template preview until after the next libraries release. /cc @jmatthiesen
src/ProjectTemplates/Microsoft.Extensions.AI.Templates/Microsoft.Extensions.AI.Templates.csproj
Outdated
Show resolved
Hide resolved
...icrosoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/dotnetcli.host.json
Outdated
Show resolved
Hide resolved
...ChatWithCustomData/ChatWithCustomData-CSharp.Web/Components/Pages/Chat/ChatSuggestions.razor
Outdated
Show resolved
Hide resolved
...ojectTemplates/Microsoft.Extensions.AI.Templates.IntegrationTests/AichatwebTemplatesTests.cs
Outdated
Show resolved
Hide resolved
...s/aichatweb.BasicAspire-as.verified/aichatweb/aichatweb.Web/Components/Pages/Chat/Chat.razor
Outdated
Show resolved
Hide resolved
....Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Program.cs
Show resolved
Hide resolved
Added a couple classifications to improve discoverability in Visual Studio.
...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json
Show resolved
Hide resolved
...plates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Components/Pages/Chat/Chat.razor
Show resolved
Hide resolved
...ates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Properties/launchSettings.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excellent! I know there are still a few pending questions and points but this is such a big and complicated area I think we should prioritize getting it merged and separately tracking the smaller follow-ups that remain.
) * Added support for OTel semantic conventions for GenAI, when using Aspire support. * Reverted changes that were not needed to enable genAI conventions. * Update src/ProjectTemplates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs Co-authored-by: Steve Sanderson <[email protected]> * Added OTel fixes for Ollama as well. --------- Co-authored-by: Steve Sanderson <[email protected]>
Adds an Aspire option to the AI Chat Web template.
All the existing AI service providers and vector databases are supported, and a new Qdrant option is now enabled when using Aspire.
Fixes #6052
Microsoft Reviewers: Open in CodeFlow