Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static parameters of type provider completion #18427

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented Mar 29, 2025

Description

Add completion for static parameters of type provider. It's surprising that we don't have this before.

图片
图片

Note:

  1. The completion only works when there is space between the < >.
  2. The completion for method style type provider (like FSharp.Data.JsonProvider< >.) only works when there is a dot after the < >.

This does not affect the type argument completion for non type provider.

图片
图片

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

Copy link
Contributor

github-actions bot commented Mar 29, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@ijklam
Copy link
Contributor Author

ijklam commented Mar 29, 2025

It seems that many tests are compiled with NO_TYPEPROVIDERS?

@smoothdeveloper
Copy link
Contributor

Not sure if it is the same issue; I noticed recently, some of the tooltip showing next parameter of TP, only shows after , but disappears when pressing space, which is annoying.

@ijklam
Copy link
Contributor Author

ijklam commented Mar 30, 2025

Not sure if it is the same issue; I noticed recently, some of the tooltip showing next parameter of TP, only shows after , but disappears when pressing space, which is annoying.

I think that's not the same issue 🌹🌹🌹

@ijklam
Copy link
Contributor Author

ijklam commented Mar 31, 2025

Don't know how to add a intellisense test with Type Providers, please feel free to tell me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants