Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the picker items do not appear when tapping on the picker after navigating through PushModalAsync #28003

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NanthiniMahalingam
Copy link
Contributor

Issue Detail

  • After navigating using PushModalAsync, picker items do not appear when tapping on the picker.

Root Cause:

  • The root view controller does not retrieve the proper UIController for the modal wrapper to present the picker controller. As a result, the picker does not display when tapped.

Description of Changes:

  • Retrieved the topmost modal wrapper view controller from RootViewController to correctly present the picker view controller.

Issues Fixed

Fixes #6101

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output

Before After
6101_before.mov
6101_after.mov

Copy link
Contributor

Hey there @NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 24, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

App.Tap("Button");
App.WaitForElement("Picker");
App.Click("Picker");
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots (Mac and Windows). Already available in the latest build.

Example:
image

Could you commit the images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots (Mac and Windows). Already available in the latest build.

Example: image

Could you commit the images?

Hi @jsuarezruiz ,

  • Pending snapshots have been committed.

@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review February 25, 2025 11:14
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner February 25, 2025 11:14
@jsuarezruiz
Copy link
Contributor

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-picker Picker community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/macOS 🍏 macOS / Mac Catalyst
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picker doesn't show options in modal
2 participants