-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix: Prevent duplicate Completed event when setting ReturnType in Entry #28018
base: main
Are you sure you want to change the base?
Conversation
Awesome stuff @bhavanesh2001! Can we add a test for this? |
@jfversluis I added a test. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
It seems like the keyboard should close when In the case of I will include a commit for this change. @PureWeen thoughts? |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
This change fixes an issue where the
Completed
event inEntry
triggers twice on Android when settingReturnType
.Root Cause
ReturnType
, Android internally updates the ImeOptions, which can cause multiple events to be fired.ImeAction.Done
,ImeAction.Search
, etc.) and physical keyboard Enter presses were not consistently handled.Completed
event is invoked once by the soft keyboard action (ImeAction
) and again by the physical Enter key press (KeyEventActions.Up
).Fix Implementation
KeyEventActions.Up
from firing unnecessarily if the event was already handled by the soft keyboard.Issues Fixed
Fixes #27992