-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.Net10] [Proposal] [iOS] TabbedPage.AutoResizeIconsProperty #28046
base: main
Are you sure you want to change the base?
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
If this makes sense, then I think It would be a good idea to do something similar for shell |
Yes! Love it! Do we have any indication how much of a performance hit this would be? I guess another approach to circumvent that is to generate an image with the right size at compile time and add _tab or something to the name and make it use that automatically. But I guess this is fine and shouldn’t even be noticed, especially on iOS. 25 is hard coded now, can we get that size programmatically from somewhere? And isn’t there a different size for the compact mode? What will this do when you turn the iPhone to landscape? |
Also, could retarget to the net10.0 branch? |
Yeah, I will do it, but later, because it is easier for me to develop on net9.0 |
Hmmm that's kind of tricky because according to Apple there are a few configurations: The 25pt is almost always used, but you're right for the compact/horizontal mode it should be 18pt. I tried to find some method to get the recommended size for the current screen from Apple's API, but they don't provide devs with this :/ |
Apple docs for tab bar and icons: https://developer.apple.com/design/human-interface-guidelines/tab-bars |
Description of Change
Maybe we can add
TabbedPage.AutoResizeIconsProperty
so that when it is set to true, the tab bar icons will be resized to Apple's recommended 25pt. Currently, devs have to manually rescale their images to make them look appealing to users, which is not a disaster, but I think they would appreciate us making it for themTabbedPage.AutoResizeIconsProperty
Screen.Recording.2025-02-26.at.01.21.12.mov