Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.Net10] [Proposal] [iOS] TabbedPage.AutoResizeIconsProperty #28046

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 26, 2025

Description of Change

Maybe we can add TabbedPage.AutoResizeIconsProperty so that when it is set to true, the tab bar icons will be resized to Apple's recommended 25pt. Currently, devs have to manually rescale their images to make them look appealing to users, which is not a disaster, but I think they would appreciate us making it for them

TabbedPage.AutoResizeIconsProperty

False True
Screen.Recording.2025-02-26.at.01.21.12.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 26, 2025
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added t/enhancement ☀️ New feature or request proposal/open platform/iOS 🍎 area-controls-tabbedpage TabbedPage and removed community ✨ Community Contribution labels Feb 26, 2025
@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 26, 2025

If this makes sense, then I think It would be a good idea to do something similar for shell

@jfversluis
Copy link
Member

Yes! Love it! Do we have any indication how much of a performance hit this would be?

I guess another approach to circumvent that is to generate an image with the right size at compile time and add _tab or something to the name and make it use that automatically. But I guess this is fine and shouldn’t even be noticed, especially on iOS.

25 is hard coded now, can we get that size programmatically from somewhere? And isn’t there a different size for the compact mode? What will this do when you turn the iPhone to landscape?

@jsuarezruiz
Copy link
Contributor

Also, could retarget to the net10.0 branch?

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 26, 2025

Also, could retarget to the net10.0 branch?

Yeah, I will do it, but later, because it is easier for me to develop on net9.0

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 26, 2025

Yes! Love it! Do we have any indication how much of a performance hit this would be?

I guess another approach to circumvent that is to generate an image with the right size at compile time and add _tab or something to the name and make it use that automatically. But I guess this is fine and shouldn’t even be noticed, especially on iOS.

25 is hard coded now, can we get that size programmatically from somewhere? And isn’t there a different size for the compact mode? What will this do when you turn the iPhone to landscape?

Hmmm that's kind of tricky because according to Apple there are a few configurations:

Screenshot 2025-02-26 at 12 48 07

The 25pt is almost always used, but you're right for the compact/horizontal mode it should be 18pt. I tried to find some method to get the recommended size for the current screen from Apple's API, but they don't provide devs with this :/

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 26, 2025

Apple docs for tab bar and icons: https://developer.apple.com/design/human-interface-guidelines/tab-bars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants