Remove restriction limiting reminders to a maximum of 49 days #9319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the maximum limit of 49.7 days on reminders.
Creating a reminder with either a dueTime or period greater than 4294967294ms results in an exception.
This was originally raised here #1298 and work was done in #6342 to switch the LocalReminderService to use IAsyncTimerFactory which handles scenarios involving intervals longer than those supported by .NET timers.
It looks like however, the parameter validation for
RegisterOrUpdateReminderwas not updated as part of that PR, so the restriction remains.There remains some risk the underlying IReminderTable implementations will make assumptions about the maximum value possible, for example the ADO.NET Reminders Table was updated to store the dueTime and period as long instead of int in this PR #6390 other implementations in the Orleans codebase appear to either use ReminderEntry directly or serialize it to Json.
Bypassing Current Limits on Reminders is mentioned as part of the proposal for Reminders V2
#7573
Microsoft Reviewers: Open in CodeFlow