Fix size used for vectorization check in BitArray (#111558) #111564
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
EgorBo
reviewed
Jan 18, 2025
| @@ -885,7 +885,7 @@ public unsafe void CopyTo(Array array, int index) | |||
| } | |||
| } | |||
| } | |||
| else if (Ssse3.IsSupported && ((uint)m_length >= Vector512<byte>.Count * 2u)) | |||
| else if (Ssse3.IsSupported && ((uint)m_length >= Vector128<byte>.Count * 2u)) | |||
There was a problem hiding this comment.
I think while you're on it, we can also replace various Sse2.And with just plain operators, e.g.
Vector128<byte> extractedLower = Sse2.And(shuffledLower, bitMask128);to
Vector128<byte> extractedLower = shuffledLower & bitMask128;but that's optional
|
Run a quick perf test that shows this is a perf improvement for all affected sizes? |
|
FWIW this would only affect pre-AVX2 X86 CPUs (or NAOT as I was informed we don't do Avx2 checks :/) else if (Avx2.IsSupported && (uint)m_length >= Vector256<byte>.Count)
...
else if (Ssse3.IsSupported && ((uint)m_length >= Vector128<byte>.Count * 2u))
...
else if (AdvSimd.Arm64.IsSupported) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #111558 by correcting the vector size used in the vectorization check within BitArray.