[main] Update dependencies from dotnet/arcade #112730
Open
+219
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…219.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25113.2 -> To Version 10.0.0-beta.25119.2
ViktorHofer
requested review from
marek-safar,
maraf,
ilonatommy,
lewing and
pavelsavara
as code owners
|
@ericstj would you mind reviewing my commits in this PR which resolve NU1511 warnings? |
ericstj
reviewed
Feb 21, 2025
| <DebuggerSupport Condition="'$(DebuggerSupport)' == '' and ('$(TargetOS)' == 'browser' or '$(TargetOS)' == 'wasi')">true</DebuggerSupport> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <!-- This test library intentionally references an inbox P2P as it needs the implementation, instead of the contract. | ||
| Suppress the NU1511 warning in the whole project as putting it on a P2P doesn't work: https://github.com/NuGet/Home/issues/14121 --> | ||
| <NoWarn>$(NoWarn);NU1511</NoWarn> |
There was a problem hiding this comment.
Good issue 👍
Another way we could workaround this in runtime centrally would be to have a target that runs during restore and removes the PrunePackageReference items that overlap with ProjectReference. Something like
<Target Name="_RemoveProjectPrunePackageReferences" AfterTargets="AddPrunePackageReferences">
<ItemGroup>
<PrunePackageReference Remove="@(ProjectReference->'%(FileName)')" />
</ItemGroup>
</Target>
ericstj
reviewed
Feb 21, 2025
...s/System.Diagnostics.DiagnosticSource/tests/System.Diagnostics.DiagnosticSource.Tests.csproj
Show resolved
Hide resolved
ericstj
reviewed
Feb 21, 2025
...IntrinsicsInSystemPrivatecoreLibAnalyzer.Tests/IntrinsicsInSystemPrivateCoreLib.Tests.csproj
Show resolved
Hide resolved
ericstj
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
Open
|
@maraf @ilonatommy please take a look at the fingerprinting test failure from the latest sdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade