Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Keep small-typedness information for return temps introduced by GDV #112733

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

jakobbotsch
Copy link
Member

Fix #112635

I tried for a while to create a reduced test case, but getting this IR requires a very specific tree of GDVs and inlines that I had a hard time creating.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 20, 2025
@jakobbotsch jakobbotsch marked this pull request as ready for review February 20, 2025 18:22
@Copilot Copilot bot review requested due to automatic review settings February 20, 2025 18:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/jit/indirectcalltransformer.cpp: Language not supported
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Feb 20, 2025

cc @dotnet/jit-contrib PTAL @AndyAyersMS @EgorBo

Diffs. A few improvements when this gets rid of unnecessary normalization.

@jakobbotsch jakobbotsch merged commit 85b2455 into dotnet:main Feb 21, 2025
110 of 113 checks passed
@jakobbotsch jakobbotsch deleted the fix-112635 branch February 21, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo build using checked runtime fails with JIT asserts
2 participants