JIT: Fix asserts from #112728 #113845
Merged
JIT: Fix asserts from #112728 #113845
+105
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
@jakobbotsch do any/all of these need regression tests? In hindsight, they were kind of obvious misses, but they don't have any test coverage outside Fuzzlyn. |
jakobbotsch
reviewed
Mar 24, 2025
This was referenced Mar 24, 2025
It would be nice. |
jakobbotsch
reviewed
Mar 24, 2025
src/tests/JIT/Regression/JitBlue/Runtime_113829/Runtime_113829.cs
Outdated
Show resolved
Hide resolved
This was referenced Mar 25, 2025
|
/ba-g Failures are azurelinux timeouts and #113877 |
|
Thanks for the quick fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113829
Fixes #113832
Both asserts from #113829 were testing assumptions that should have been checked in the condition instead. Since casts from small types both have TYP_INT actual type, either byte or short args match the IR type for either overload of
Vector###.Create, so an extra cast is needed when the sizes don't match.#113832 is a case where
BroadcastScalarToVectorwas allowed to containCreateScalar([GT_LONG]). There was already a check that prevented containment ofCreateScalarUnsafeof a decomposed long, andCreateScalarshould have followed the same path.