dotnet watch run shouldn't disable the browser refresh logic inject…
#15340
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion on Linux Prior to this change, inability or failure to launch a browser would result in the browser-refresh feature from being disabled. On Linux the feature is a bit flaky so we always disabled it. This change loosens up some of the restrictions. We always attempt to launch a browser and use heuristics to determine if launching failed. Additionally, the browser refresh feature is enabled regardless of how launching the browser fared. Fixes #27081
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotalik
approved these changes
Jan 14, 2021
|
Porting over dotnet/aspnetcore#28519 and enabling tests. |
captainsafia
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion on Linux
Prior to this change, inability or failure to launch a browser would result in the browser-refresh feature from being disabled.
On Linux the feature is a bit flaky so we always disabled it. This change loosens up some of the restrictions.
We always attempt to launch a browser and use heuristics to determine if launching failed. Additionally,
the browser refresh feature is enabled regardless of how launching the browser fared.
Fixes #27081