Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CA2022 suppressions #47904

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary CA2022 suppressions #47904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
88681c6
Remove unnecessary CA2022 suppressions
Winniexu01 Mar 26, 2025
e0381c0
Remove unnecessary CA2022 suppressions
Winniexu01 Mar 28, 2025
1b0f15a
Merge branch 'main' into CA2022
Winniexu01 Mar 28, 2025
55a19bf
Merge branch 'main' into CA2022
Winniexu01 Mar 31, 2025
572e2cb
Merge branch 'main' into CA2022
Winniexu01 Mar 31, 2025
57ed326
Define ReadExactlyAsync a an extension method
Winniexu01 Mar 31, 2025
5a33018
Format extension method
Winniexu01 Mar 31, 2025
cb67d01
Fix: remove the equal sigan
Winniexu01 Mar 31, 2025
498d187
Merge branch 'main' into CA2022
Winniexu01 Mar 31, 2025
f9f678d
Revert - disable CA2022 warnings for ReadAsync
Winniexu01 Apr 1, 2025
77b7e23
Merge branch 'main' into CA2022
Winniexu01 Apr 2, 2025
626eb60
Merge branch 'main' into CA2022
Winniexu01 Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions test/dotnet-sln.Tests/GivenDotnetSlnAdd.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,9 +583,22 @@ public void WhenProjectIsAddedSolutionHasUTF8BOM(string solutionCommand)
using (var stream = new FileStream(Path.Combine(projectDirectory, "App.sln"), FileMode.Open))
{
var bytes = new byte[preamble.Length];
#pragma warning disable CA2022 // Avoid inexact read
stream.Read(bytes, 0, bytes.Length);
#pragma warning restore CA2022 // Avoid inexact read
#if NET
stream.ReadExactly(bytes, 0, bytes.Length);
#else
int offset = 0;
int count = bytes.Length;
while (count > 0)
{
int read = stream.Read(bytes, offset, count);
if (read <= 0)
{
throw new EndOfStreamException();
}
offset += read;
count -= read;
}
#endif
bytes.Should().BeEquivalentTo(preamble);
}
}
Expand Down
19 changes: 16 additions & 3 deletions test/dotnet-sln.Tests/GivenDotnetSlnRemove.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,9 +545,22 @@ public void WhenProjectIsRemovedSolutionHasUTF8BOM(string solutionCommand)
using (var stream = new FileStream(Path.Combine(projectDirectory, "App.sln"), FileMode.Open))
{
var bytes = new byte[preamble.Length];
#pragma warning disable CA2022 // Avoid inexact read
stream.Read(bytes, 0, bytes.Length);
#pragma warning restore CA2022 // Avoid inexact read
#if NET
stream.ReadExactly(bytes, 0, bytes.Length);
#else
int offset = 0;
int count = bytes.Length;
while (count > 0)
{
int read = stream.Read(bytes, offset, count);
if (read <= 0)
{
throw new EndOfStreamException();
}
offset += read;
count -= read;
}
#endif
bytes.Should().BeEquivalentTo(preamble);
}
}
Expand Down