-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest application insights #47924
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- eng/Versions.props: Language not supported
We will need to backport this as they marked version 22 as deprecated but I want to get this into main first and make sure everything is still working. |
@dotnet/product-construction looks like this is generating a prebuilt error. This shouldn't be used in the source build builds. Where does it need to be marked as there's no prebuilt-baseline.xml in the repo? |
Appinsights is part of source-build-externals: https://github.com/dotnet/source-build-externals/tree/main/src |
Needs a bump to 2.23.0 |
It is part of the source-build graph today and therefore is part of source-build-externals as Mitchell said. Overall the desire is for the source-build product to be as close as possible to the MSFT product (see dotnet/source-build#4010). Adding flags to include/exclude features like this would be preferable over a hard exclusion from source build. |
I've updated Application Insights to version 2.23.0 in dotnet/source-build-externals#463 |
No description provided.