Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest application insights #47924

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 26, 2025 21:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/Versions.props: Language not supported

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 26, 2025
@marcpopMSFT
Copy link
Member Author

We will need to backport this as they marked version 22 as deprecated but I want to get this into main first and make sure everything is still working.

@marcpopMSFT
Copy link
Member Author

@dotnet/product-construction looks like this is generating a prebuilt error. This shouldn't be used in the source build builds. Where does it need to be marked as there's no prebuilt-baseline.xml in the repo?
/__w/1/vmr/repo-projects/Directory.Build.targets(956,5): warning : 1 new packages used not in baseline! See report at /__w/1/vmr/artifacts/prebuilt-report/baseline-comparison.xml for more information. Package IDs are: [/__w/1/vmr/repo-projects/dotnet.proj] /__w/1/vmr/repo-projects/Directory.Build.targets(956,5): warning : Microsoft.ApplicationInsights.2.23.0 [/__w/1/vmr/repo-projects/dotnet.proj] /__w/1/vmr/repo-projects/Directory.Build.targets(956,5): warning : Prebuilt usages are different from the baseline. If detected changes are acceptable, update baseline with: [/__w/1/vmr/repo-projects/dotnet.proj] /__w/1/vmr/repo-projects/Directory.Build.targets(956,5): warning : cp '/__w/1/vmr/artifacts/prebuilt-report/generated-new-baseline.xml' '/__w/1/vmr/eng/tools/prebuilt-baseline.xml' [/__w/1/vmr/repo-projects/dotnet.proj]

@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

Appinsights is part of source-build-externals: https://github.com/dotnet/source-build-externals/tree/main/src

@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

Needs a bump to 2.23.0

@MichaelSimons
Copy link
Member

@dotnet/product-construction looks like this is generating a prebuilt error. This shouldn't be used in the source build builds. Where does it need to be marked as there's no prebuilt-baseline.xml in the repo?

It is part of the source-build graph today and therefore is part of source-build-externals as Mitchell said. Overall the desire is for the source-build product to be as close as possible to the MSFT product (see dotnet/source-build#4010). Adding flags to include/exclude features like this would be preferable over a hard exclusion from source build.

@v-wuzhai
Copy link
Member

v-wuzhai commented Apr 2, 2025

I've updated Application Insights to version 2.23.0 in dotnet/source-build-externals#463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants